fix(core): use serve-handler fork to remove annoying punycode warning#10442
Merged
fix(core): use serve-handler fork to remove annoying punycode warning#10442
Conversation
slorber
added
the
pr: maintenance
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +381 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
Josh-Cena
approved these changes
Aug 23, 2024
Collaborator
Josh-Cena
left a comment
Josh-Cena
left a comment
There was a problem hiding this comment.
Is there a reason we don't just change our source code to use the forked package?
Collaborator
Author
I hesitated to change the import names, but this means |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using Node 22, everytime we run Docusaurus we see an annoying warning:
serve-handler hasn't been maintained for a while so I created a
@docusaurus/serve-handlerfork just to get rid of it:https://github.com/slorber/docusaurus-serve-handler
Fix vercel/serve-handler#204
Fix #10107
Test Plan
CI + local test
Test links
https://deploy-preview-10442--docusaurus-2.netlify.app/
Related issues/PRs