Conversation
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +392 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
slorber
force-pushed
the
slorber/add-rsdoctor
branch
from
d283a29 to
6fbce2f
Compare
slorber
commented
Aug 20, 2024
Comment on lines
+11
to
+14
| // TODO Shitty workaround to bypass lib typechecking | ||
| // package does not work will with skipLibCheck false | ||
| // eslint-disable-next-line | ||
| const {RsdoctorWebpackMultiplePlugin} = require('@rsdoctor/webpack-plugin'); |
Collaborator
Author
There was a problem hiding this comment.
Not fan of this but will merge the PR as-is until the Rsdoctor maintainer gives me feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This plugin is quite useful for checking bundler performance.
It was originally created for Rspack but can also work with Webpack so let's add it now to our website and use it to find out low hanging fruits we could optimize before upgrading to Rspack (see #10402)
Test Plan
CI keeps working
Local test of the plugin
Test links
https://deploy-preview-10418--docusaurus-2.netlify.app/