-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Closed
Labels
bugAn error in the Docusaurus core causing instability or issues with its executionAn error in the Docusaurus core causing instability or issues with its executiondifficulty: starterIssues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.status: accepting prThis issue has been accepted, and we are looking for community contributors to implement thisThis issue has been accepted, and we are looking for community contributors to implement this
Description
Have you read the Contributing Guidelines on issues?
- I have read the Contributing Guidelines on issues.
Prerequisites
- I'm using the latest version of Docusaurus.
- I have tried the
npm run clearoryarn clearcommand. - I have tried
rm -rf node_modules yarn.lock package-lock.jsonand re-installing packages. - I have tried creating a repro with https://new.docusaurus.io.
- I have read the console error message carefully (if applicable).
Description
Right now the 🌞/🌜 light/dark mode toggle checkbox has the aria-label "Switch between dark and light mode". "Checked" and "not checked" are ambiguous terms without more context because some websites default to dark mode and/or don't respect system defaults.
I realize it might seem at first like the group of people who want a screenreader and care about light vs dark mode might seem small. A couple quick scenarios that come to mind:
- Some folks such as low vision or with reading difficulties use screenreaders to assist with difficult-to-understand pages
- Some folks can't see the website in one mode, and can only see it in the other
Steps to reproduce
- Open a screenreader such as NVDA on Windows or VoiceOver on Mac
- Put screenreader/text focus on the light/dark mode toggle
Expected behavior
I'm not an expert here, but maybe a message like...
switch from light to dark mode checkbox, not checked
...or maybe use a button instead of a checkbox behind the scenes?
switch between light and dark mode checkbox (current value light)
Actual behavior
The narration by default in light mode is roughly:
switch between light and dark mode checkbox, not checked
Your environment
- Public source code: https://github.com/typescript-eslint/typescript-eslint
- Public site URL: https://typescript-eslint.io
- Docusaurus version used: 2.0.0-beta.15
- Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 89
- Operating system and version (e.g. Ubuntu 20.04.2 LTS): Windows 10
Reproducible demo
https://typescript-eslint.io
Self-service
- I'd be willing to fix this bug myself.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugAn error in the Docusaurus core causing instability or issues with its executionAn error in the Docusaurus core causing instability or issues with its executiondifficulty: starterIssues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan.status: accepting prThis issue has been accepted, and we are looking for community contributors to implement thisThis issue has been accepted, and we are looking for community contributors to implement this