Skip to content

Adds the configuration for PnP/Typescript#6856

Merged
iansu merged 4 commits intofacebook:masterfrom
arcanis:resolve-module-name-module
May 1, 2019
Merged

Adds the configuration for PnP/Typescript#6856
iansu merged 4 commits intofacebook:masterfrom
arcanis:resolve-module-name-module

Conversation

@arcanis
Copy link
Copy Markdown
Contributor

@arcanis arcanis commented Apr 20, 2019

The fork-ts-checker-webpack-plugin package just released an update that allows to specify custom resolution schemes. This makes it possible for Create-React-App to have native PnP support even when using TypeScript.

I've tested this diff locally and it seemed to work.

@arcanis arcanis mentioned this pull request Apr 20, 2019
Open
@johnnyreilly
Copy link
Copy Markdown
Contributor

johnnyreilly commented Apr 20, 2019

Fast work!

Question: I don't see usage of the https://github.com/arcanis/pnp-webpack-plugin in this PR. Is use of the pnp-webpack-plugin no longer required when working with webpack?

@arcanis
Copy link
Copy Markdown
Contributor Author

arcanis commented Apr 20, 2019

Until webpack/enhanced-resolve#168 gets merged the pnp-webpack-plugin package is needed for everything that uses enhanced-resolve (basically Webpack itself). Since it's already been configured in #5136 I don't need to add anything else.

In the case of TypeScript, since it uses its own resolution instead of enhanced-resolve, the only package that I need to add is ts-pnp, which connects the living PnP environment with the existing TypeScript resolution algorithms.

@ianschmitz ianschmitz added this to the 3.x milestone Apr 20, 2019
@ianschmitz
Copy link
Copy Markdown
Contributor

ianschmitz commented Apr 21, 2019

Thanks @arcanis. Does Jest work as expected with this PR?

@arcanis
Copy link
Copy Markdown
Contributor Author

arcanis commented Apr 21, 2019 •
edited
Loading

Yep - running yarn test then pressing a got the default test green.

As far as I can remember, Jest just uses Babel to strip the TS types, so no particular TS resolution involved - it simply uses the classic Jest resolution (which supports PnP out of the box since 24.5).

@crubier
Copy link
Copy Markdown

crubier commented Apr 24, 2019

Can't wait for this aha

@iansu iansu modified the milestones: 3.x, 3.0.1 Apr 24, 2019
@iansu iansu self-assigned this Apr 24, 2019
@arcanis
Copy link
Copy Markdown
Contributor Author

arcanis commented May 1, 2019

Any blocker?

@iansu
Copy link
Copy Markdown
Contributor

iansu commented May 1, 2019

No, I think this looks good. Thanks for the reminder. 😀

@iansu iansu merged commit b36d1ea into facebook:master May 1, 2019
@iansu
Copy link
Copy Markdown
Contributor

iansu commented May 1, 2019

Thanks! ❤️

@lock lock Bot locked and limited conversation to collaborators May 6, 2019
@arcanis arcanis deleted the resolve-module-name-module branch May 21, 2019 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@gaearon gaearon Awaiting requested review from gaearon

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

@Timer Timer Awaiting requested review from Timer

Assignees

@iansu iansu

Labels

CLA Signed tag: enhancement

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

6 participants

@arcanis @johnnyreilly @ianschmitz @crubier @iansu @facebook-github-bot