Add directory details to packages/* package.json#6826
Merged
ianschmitz merged 1 commit intofacebook:masterfrom Apr 16, 2019
feelepxyz:add-repo-directory
Merged
Add directory details to packages/* package.json#6826ianschmitz merged 1 commit intofacebook:masterfrom feelepxyz:add-repo-directory
ianschmitz merged 1 commit intofacebook:masterfrom
feelepxyz:add-repo-directory
Conversation
Specifying the directory as part of the repository field in a package.json allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in [npm/rfcs#19](npm/rfcs#19).
feelepxyz
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
Contributor
|
Thanks! |
Contributor
|
Thanks @feelepxyz - can you provide details of any packages using this approach now (this is for my own interest) :) |
Contributor
Author
|
@mrmckeb yes we're using at @dependabot to link to the package and commit view from the PRs we create. Here's an example: benbrandt/movie-list#14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.
This format was accepted by npm in npm/rfcs#19.