Skip to content

Add example command to create typed project #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbelsky wants to merge 1 commit into from
Closed

Add example command to create typed project #5766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docusaurus/docs/adding-typescript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ title: Adding TypeScript

[TypeScript](https://www.typescriptlang.org/) is a typed superset of JavaScript that compiles to plain JavaScript.

To create a typed React App project run it:
Copy link
Copy Markdown
Contributor

@mrmckeb mrmckeb Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing this to "To start a new Create React App project with TypeScript, you can run:"

You could also add the Yarn way of doing this, as below (with # or), which would be yarn create react-app my-app --typescript.

Copy link
Copy Markdown
Contributor Author

@mbelsky mbelsky Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for feedback. Unfortunately I've deleted the source repo. Could I change that with a new PR?

Copy link
Copy Markdown
Contributor

@mrmckeb mrmckeb Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to add commits to the PR here, in GitHub directly @mbelsky.

Copy link
Copy Markdown
Contributor Author

@mbelsky mbelsky Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand to do that the source branch should exist, but it isn't

Copy link
Copy Markdown
Contributor

@mrmckeb mrmckeb Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that issue too. Can you create a new PR? I'll close this one off.

Copy link
Copy Markdown
Contributor Author

@mbelsky mbelsky Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New PR: #6015

```bash
$ npx create-react-app my-app --typescript
```

To add [TypeScript](https://www.typescriptlang.org/) to a Create React App project, first install it:

```bash
Expand Down