Add example command to create typed project#5766
Add example command to create typed project#5766mbelsky wants to merge 1 commit intofacebook:masterfrom mbelsky:patch-1
Conversation
mrmckeb
left a comment
mrmckeb
left a comment
There was a problem hiding this comment.
Good idea, and thanks for the PR. Let me know if you have any questions on the feedback.
|
|
||
| [TypeScript](https://www.typescriptlang.org/) is a typed superset of JavaScript that compiles to plain JavaScript. | ||
|
|
||
| To create a typed React App project run it: |
There was a problem hiding this comment.
Would you mind changing this to "To start a new Create React App project with TypeScript, you can run:"
You could also add the Yarn way of doing this, as below (with # or), which would be yarn create react-app my-app --typescript.
There was a problem hiding this comment.
Thank you for feedback. Unfortunately I've deleted the source repo. Could I change that with a new PR?
There was a problem hiding this comment.
You should be able to add commits to the PR here, in GitHub directly @mbelsky.
There was a problem hiding this comment.
As I understand to do that the source branch should exist, but it isn't
There was a problem hiding this comment.
Yes, I see that issue too. Can you create a new PR? I'll close this one off.
|
Closing as source branch was deleted and changes cannot be made. New PR will be opened shortly. |
4 participants
Hey,
I've found this command in v2.1.0 release notes and I think it's important to have it in docs. However I'm not sure that this file is a correct place to put that example.
What is your opinion on this?