Add "edit" feature to Docusaurus pages#5492
Merged
Timer merged 1 commit intofacebook:masterfrom Oct 21, 2018
Merged
Conversation
20 tasks
Contributor
|
Looks great! |
Contributor
|
What happens if the user isn't a collaborator? Does it automatically fork to their account and reroute the URL? |
Contributor
|
@Timer I'm pretty sure that's how this works. I've used GitHub's editing functionality to contribute to the docs of other projects in the past and I think it created a fork for me first. I'm pretty sure it also walks you though the process of turning your edits in your fork into a PR. |
Contributor
|
I just tried this on the Jest README:
|
iansu
approved these changes
Oct 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "edit" button on the page, making it easy to contribute to docs. See: https://docusaurus.io/docs/en/site-config#editurl-string
IS:
