Add some front page content#5398
Conversation
| content: `With Create React App, you get to focus on **writing React, not boilerplate**. | ||
| All you need to do is run a command, install some dependencies, and decide what's for dinner. | ||
|
|
||
| npx create-react-app my-app |
There was a problem hiding this comment.
Maybe we can tweak the CSS so the left hand side margin isn't so large in code blocks, what do you think?
There was a problem hiding this comment.
Sure I'll try to tune it down a bit :)
There was a problem hiding this comment.
Ah, that's actually indentation - I'll just remove the indentation and we should be good 👍
There was a problem hiding this comment.
Cool, yeah it seemed not as large in the .md files.
How did you generate https://create-react-app-stngeqjqos.now.sh/? When poking around, I followed this and pulled your branch locally.
There was a problem hiding this comment.
How did you generate https://create-react-app-stngeqjqos.now.sh/?
I use now from zeit - it's free and pretty easy to use. Once you've installed their CLI and logged in, you can do something like:
cd docusaurus/webpage
yarn build # to generate the html files
cd build/create-react-app # this is where the built files are
now # deploy to a unique URLThere was a problem hiding this comment.
Thanks! I'll have to check that out, and carbon too
| { | ||
| title: 'Webpack 4', | ||
| content: | ||
| 'Webpack 4 gives you lightning fast rebuilds and code-splitting out of the box', |
There was a problem hiding this comment.
Consider punctuation (e.g. add periods) throughout to be consistent?
There was a problem hiding this comment.
I landed on removing the punctuation that was there, as i thought it looked better with no punctuation than a period after a ton of one-sentence paragraphs. Totally agree that it should be consistent!
There was a problem hiding this comment.
Thanks
I guess not sure since some have two sentences? If you prefer no periods, prob better to just leave it as it was... periods for the two sentences, no punctuation for the others...
amyrlam
left a comment
amyrlam
left a comment
There was a problem hiding this comment.
👍 looks good, i'd say let's get this in!
3 participants
Preview: https://create-react-app-stngeqjqos.now.sh
This pull request adds some content to the front page, and fixes a design faux-pas with the mobile navigation.
This doesn't need to be the final content, of course, but it's a lot better than not having anything 👍
I created the update screenshot with carbon, which can be updated quite easily later if we want.
Addresses #5238