Add callouts and logo#5341
Merged
selbekk merged 2 commits intofacebook:docusaurusfrom Oct 8, 2018
Merged
Conversation
20 tasks
Contributor
|
Not sure about the Travis failure https://travis-ci.org/facebook/create-react-app/jobs/438291393#L2874, but it seems like it can be merged to |
Contributor
Author
|
Yeah all of my PRs have failed their Travis check, but it doesn't look like anything related to my code. Merging then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the front page of the docs a bit, as it contained a few sections we don't need for a first release.
The React logo was borrowed from the template folder - I guess it's fine to duplicate like this?
Adresses #5238