Skip to content

Configure which browser to open in npm start (#873) #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gaearon merged 1 commit into from
Dec 11, 2016
Merged

Configure which browser to open in npm start (#873) #1148

gaearon merged 1 commit into from
Dec 11, 2016
+2 −1

Conversation

@GAumala
Copy link
Contributor

@GAumala GAumala commented Dec 4, 2016

Use a 'BROWSER' environment variable with npm start to specify which
browser to open. if the value of 'BROWSER' is not valid executable file,
don't open any browser.

@GAumala
Configure which browser to open in npm start (facebook#873)
8116195 
Use a 'BROWSER' environment variable with npm start to specify which
browser to open. if the value of 'BROWSER' is not valid executable file,
don't open any browser.
@facebook-github-bot
Copy link

facebook-github-bot commented Dec 4, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 4, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon mentioned this pull request Dec 5, 2016
Closed
@gaearon gaearon added this to the 0.9.0 milestone Dec 5, 2016
@gaearon gaearon mentioned this pull request Dec 5, 2016
Closed
@gaearon gaearon merged commit 759806e into facebook:master Dec 11, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 11, 2016

Thank you!

This was referenced Dec 11, 2016
Merged
Closed
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@GAumala @alexdriaguine
Configure which browser to open in npm start (facebook#873) (facebook…
2457f13 
…#1148)

Use a 'BROWSER' environment variable with npm start to specify which
browser to open. if the value of 'BROWSER' is not valid executable file,
don't open any browser.
@gaearon gaearon mentioned this pull request Feb 24, 2017
Closed
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@GAumala @randycoulman
Configure which browser to open in npm start (facebook#873) (facebook…
e8987ae 
…#1148)

Use a 'BROWSER' environment variable with npm start to specify which
browser to open. if the value of 'BROWSER' is not valid executable file,
don't open any browser.
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed tag: new feature

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@GAumala @facebook-github-bot @gaearon