Skip to content

Conversation

@zhukevgeniy
Copy link

No description provided.

@facebook-github-bot
Copy link

Hi @zhukevgeniy!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@raix
Copy link
Contributor

raix commented Dec 4, 2020

seems related to #10121

@raix raix mentioned this pull request Dec 4, 2020
25 tasks
@dudeisbrendan03
Copy link

seems related to #10121

Implementation seems more simple and efficient than #10121

@clwilkening
Copy link

Would love for this fix to get merged.
Is there any update?

@tdeekens
Copy link

We now use this changeset as a patch-package but would also love to see this moving into main :)

@raix
Copy link
Contributor

raix commented May 26, 2021

I've merged one of the 3 solutions into the wp5 update branch

@tdeekens
Copy link

I've merged one of the 3 solutions into the wp5 update branch

Awesome. Thanks a lot.

@mrmckeb mrmckeb mentioned this pull request May 30, 2021
@mrmckeb
Copy link
Contributor

mrmckeb commented May 30, 2021

Hi @zhukevgeniy, thanks for your time on this. After a discussion with @raix, we're closing this in favour of #10121 and plan to have this out in the next minor release. Please let us know if you have any issues after that time!

@mrmckeb mrmckeb closed this May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants