fix(text): apply explicit size overrides#3648
Merged
Merged
Conversation
ahfoysal
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
July 7, 2026 06:06
|
@ahfoysal is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
approved these changes
Jul 7, 2026
cixzhang
left a comment
cixzhang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. This looks god and is complete with the theming system as well.
cixzhang
enabled auto-merge (squash)
July 7, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Textsizeprop as an explicit font-size overridetypeline-height, weight, and font-family behaviorsizethroughthemeProps/data-sizeso theming can target itFixes #3615.
Tests
pnpm vitest run packages/core/src/Text/Text.test.tsxpnpm exec eslint packages/core/src/Text/Text.tsx packages/core/src/Text/text.stylex.ts packages/core/src/Text/Text.test.tsxpnpm exec prettier --check packages/core/src/Text/Text.tsx packages/core/src/Text/text.stylex.ts packages/core/src/Text/Text.test.tsx .changeset/text-size-override.mdpnpm check:changesetsgit diff --checkNote: the commit hook also ran
pnpm check:repo.