fix(Selector): forward extra HTML attributes from XDSBaseProps#1444
Merged
Conversation
XDSSelector destructured only specific props from XDSBaseProps (xstyle, className, style, data-testid) and silently dropped all other HTML attributes like data-*, aria-*, title, onFocus, onBlur, etc. Collect remaining props with a rest spread and forward them to the trigger <button> element, matching the pattern used by XDSButton and other components. Fixes #1415
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
added a commit
that referenced
this pull request
Apr 26, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
cixzhang
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XDSSelectoracceptsXDSBaseProps(which extendsReact.HTMLAttributes), but was destructuring onlyxstyle,className,style, anddata-testid— silently dropping all other HTML attributes (data-*,aria-*,title,onFocus,onBlur, etc.).Fix
...restspread in the destructuring...restonto the trigger<button>elementhasClearfrom the destructuring (was previously accessed via'hasClear' in props) to prevent it from leaking to the DOMThis matches the pattern used by
XDSButtonand other components that extendXDSBaseProps.Fixes #1415