Upgrade Docusaurus to 3.8.1-canary-6401#4340
Closed
CristianLara wants to merge 1 commit intofacebook:mainfrom
Closed
Upgrade Docusaurus to 3.8.1-canary-6401#4340CristianLara wants to merge 1 commit intofacebook:mainfrom
CristianLara wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: We recently noticed that the copy feature on our website codeblocks were excluding indentation. There's a github issue on the docusaurus repo tracking this facebook/docusaurus#11414 with a fix that was just merged today facebook/docusaurus#11422. To avoid waiting until their next release we have two options: 1. update our website package.json to use a docusaurus canary until they release 3.9 2. swizzle the relevant docusaurus code and fix it ourselves using their well documented api. There's an example of another project replacing this same logic that we can use. Though it will become unnecessary once docusaurus 3.9 releases We're going with option (1) here and upgrading Docusaurus to version 3.8.1-canary-6401 across Ax and BoTorch. The docusaurus team releases canaries regularly and are what they use to build their website. https://docusaurus.io/community/canary Differential Revision: D83068096
meta-cla
bot
added
the
CLA Signed
Contributor
|
@CristianLara has exported this pull request. If you are a Meta employee, you can view the originating diff in D83068096. |
Contributor
|
This pull request has been merged in ef638b4. |
facebook-github-bot
pushed a commit
to meta-pytorch/botorch
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: #3021 X-link: facebook/Ax#4340 We recently noticed that the copy feature on our website codeblocks were excluding indentation. There's a github issue on the docusaurus repo tracking this facebook/docusaurus#11414 with a fix that was just merged today facebook/docusaurus#11422. To avoid waiting until their next release we have two options: 1. update our website package.json to use a docusaurus canary until they release 3.9 2. swizzle the relevant docusaurus code and fix it ourselves using their well documented api. There's an example of another project replacing this same logic that we can use. Though it will become unnecessary once docusaurus 3.9 releases We're going with option (1) here and upgrading Docusaurus to version 3.8.1-canary-6401 across Ax and BoTorch. The docusaurus team releases canaries regularly and are what they use to build their website. https://docusaurus.io/community/canary Reviewed By: mpolson64 Differential Revision: D83068096 fbshipit-source-id: d88084af7f58803d798e7f4348e028053e1f3012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We recently noticed that the copy feature on our website codeblocks were excluding indentation. There's a github issue on the docusaurus repo tracking this facebook/docusaurus#11414 with a fix that was just merged today facebook/docusaurus#11422.
To avoid waiting until their next release we have two options:
update our website package.json to use a docusaurus canary until they release 3.9
swizzle the relevant docusaurus code and fix it ourselves using their
well documented api. There's an example of another project replacing this same logic that we can use. Though it will become unnecessary once docusaurus 3.9 releases
We're going with option (1) here and upgrading Docusaurus to version 3.8.1-canary-6401 across Ax and BoTorch. The docusaurus team releases canaries regularly and are what they use to build their website. https://docusaurus.io/community/canary
Differential Revision: D83068096