This repository was archived by the owner on Jun 19, 2024. It is now read-only.
increasing the service name length to 63 to reflect the updated limits in kubernetes v1.4.0#857
Merged
fusesource-ci merged 1 commit intofabric8io:masterfrom Mar 13, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #857 +/- ##
=========================================
Coverage 18.16% 18.16%
Complexity 473 473
=========================================
Files 160 160
Lines 8279 8279
Branches 1484 1484
=========================================
Hits 1504 1504
Misses 6603 6603
Partials 172 172Continue to review full report at Codecov.
|
pldimitrov
changed the title
…s in kubernetes v1.4.0
Author
|
Hi there, we were having issues with the plugin truncating service names and I noticed this was fixed in Kubernetes v1.4.0-alpha.3 (kubernetes/kubernetes#29523) so it seems like there is no reason to keep the service names limited to 24 characters anymore. |
Contributor
|
Thanks ! looks good to me [merge] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#206
kubernetes/kubernetes#12463
kubernetes/kubernetes#25041
kubernetes/kubernetes#28005