Bump CIRC, fix CI build, add lifetime annotations #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build now works with rust 1.63 (when using backtrace = "=0.3.68")
Uing makefiles and parallel build seems to cause errors in CI.
This caused compiler errors for rust >= 1.65
Newer toolchains cause stack overflow errors in some tests. That may be related to a memory alignment change in Rust v1.67 (rust-lang/rust#102750)
…NOREs The common_cells test was already failing as of 37f9596 The removed ignores referenced issues that have been closed and the tests pass now.
Contributor
Author
Collaborator
Owner
|
Awesome, thanks a lot 🎉! Let me kick off the CI run here as well. |
jgreenbaum
pushed a commit
to jgreenbaum/moore-stefan
that referenced
this pull request
Jun 25, 2025
But tests fail as mentioned in the comments to the existing pull request: "Building moore with v1.67 or newer results in stack overflows at runtime (e.g. when running the tests). I think fixing this can be deferred for now.": fabianschuiki#252
|
Since this wasn't committed, I've submitted a PR on Stefan's branch that brings moor up to rustc 1.87.0 and fixes the stack overflows mentioned in this PR. I hope this is useful. |
Owner
|
Oh thanks for resurfacing this. Let me hit merge on this here as well, just in case 👍. A lot of the Moore work has migrated over into CIRCT directly, which might also be useful depending on what you are doing 😃 |
jgreenbaum
pushed a commit
to jgreenbaum/moore-fabian
that referenced
this pull request
Jul 9, 2025
But tests fail as mentioned in the comments to the existing pull request: "Building moore with v1.67 or newer results in stack overflows at runtime (e.g. when running the tests). I think fixing this can be deferred for now.": fabianschuiki/moore#252
jgreenbaum
pushed a commit
to jgreenbaum/moore-stefan
that referenced
this pull request
Jul 9, 2025
But tests fail as mentioned in the comments to the existing pull request: "Building moore with v1.67 or newer results in stack overflows at runtime (e.g. when running the tests). I think fixing this can be deferred for now.": fabianschuiki#252
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CI workflow run: https://github.com/stefanlippuner/moore/actions/runs/6361816938