wamr: fix wasi_proc_exit segfault #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
fix-proc-exit
branch
from
656658b to
f89bc99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
==========================================
+ Coverage 68.40% 68.51% +0.10%
==========================================
Files 71 71
Lines 6935 6943 +8
==========================================
+ Hits 4744 4757 +13
+ Misses 2191 2186 -5 ☔ View full report in Codecov by Sentry. |
csegarragonz
force-pushed
the
fix-proc-exit
branch
8 times, most recently
from
4e43053 to
d288b72
Compare
csegarragonz
force-pushed
the
fix-proc-exit
branch
from
d288b72 to
d61d0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the right thread environment for threads executing WAMR modules. It fixes a long-standing segmentation fault with
wasi_proc_exitand also allows to remove anifdefin our WAMR fork about OS threads being initialised.Follow-up:
seguePR?