Skip to content

Commit 6a1d78d

Browse files
committed
fix(isLatLong): fix bug on isLatLang
- when lat starts with (, it makes it a true latitude. - Closes validatorjs#929
1 parent 54bf8c4 commit 6a1d78d

5 files changed

Lines changed: 9 additions & 1 deletion

File tree

‎lib/isLatLong.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ function _default(str) {
1616
(0, _assertString.default)(str);
1717
if (!str.includes(',')) return false;
1818
var pair = str.split(',');
19+
if (pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')' || pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(') return false;
1920
return lat.test(pair[0]) && long.test(pair[1]);
2021
}
2122

‎src/lib/isLatLong.js‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,9 @@ export default function (str) {
77
assertString(str);
88
if (!str.includes(',')) return false;
99
const pair = str.split(',');
10+
if (
11+
(pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')') ||
12+
(pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(')
13+
) return false;
1014
return lat.test(pair[0]) && long.test(pair[1]);
1115
}

‎test/validators.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6523,6 +6523,8 @@ describe('Validators', () => {
65236523
'-112.96381, -160.96381',
65246524
'-90., -180.',
65256525
'+90.1, -180.1',
6526+
'(-17.738223, 85.605469',
6527+
'0.955766, -19.863281)',
65266528
'+,-',
65276529
'(,)',
65286530
',',

‎validator.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1739,6 +1739,7 @@ var isLatLong = function (str) {
17391739
assertString(str);
17401740
if (!str.includes(',')) return false;
17411741
var pair = str.split(',');
1742+
if (pair[0].charAt(0) === '(' && pair[1].charAt(pair[1].length - 1) !== ')' || pair[1].charAt(pair[1].length - 1) === ')' && pair[0].charAt(0) !== '(') return false;
17421743
return lat.test(pair[0]) && _long.test(pair[1]);
17431744
};
17441745

‎validator.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)