Remove remaining double operations #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Mathew, please reform this PR to be against the development, rather than the master, branch... changes go on that branch. I will then gladly review it. |
matthew-reynolds
force-pushed
the
no-doubles
branch
from
fa38118 to
a8cfdb0
Compare
Author
|
@eyalroz thanks - Rebased against |
Owner
|
Oh, I see, how careless of me, I forgot to cast the literals. Thanks for noticing. |
Owner
|
Please poke me in a couple of weeks or so - maybe it's time I made another release. |
eyalroz
added
bug
Owner
|
v6.3.0 has been released with the fix integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #84 / 25bd5df.
The
PRINTF_USE_DOUBLE_INTERNALLYmacro can be used to select whether the library usesdoubleorfloattypes for internal floating-point calculations. However, there still exist a few expressions that contain uncasted floating point literals, resulting indouble-typed literals and thusdouble-precision operations. Cast these literals tofloating_point_tto remove remainingdoubleoperations when usingfloats internally.Tested in an embedded environment that prohibits
doubles (Except forf2dandd2f, for passingfloats through the varargs).All unit tests pass.