Skip to content

chore: pin wazero to main commit for now#75

Merged
zshipko merged 1 commit intomainfrom
pin-wazero-main
Sep 16, 2024
Merged

chore: pin wazero to main commit for now#75
zshipko merged 1 commit intomainfrom
pin-wazero-main

Conversation

@zshipko
Copy link
Copy Markdown
Contributor

@zshipko zshipko commented Sep 16, 2024

We can wait until the next wazero release to make another release of the go-sdk, but for now using the latest wazero on main will unblock the testing of the python pdk

@zshipko
Copy link
Copy Markdown
Contributor Author

zshipko commented Sep 16, 2024

@nilslice
Copy link
Copy Markdown
Member

@zshipko, hmm... I don't, but I have a change to that test here in #74 (unmerged):
https://github.com/extism/go-sdk/pull/74/files#diff-0ce78c2bb443b7841d9e5aac51ecf3b4739860b7c29cc113aac745616ca3cc77R504-R509

The failing test actual output includes a trace log, vs. the expected which doesn't. So maybe we merged a new log.wasm that includes it, but didn't update the test to expect the trace log?

@zshipko
Copy link
Copy Markdown
Contributor Author

zshipko commented Sep 16, 2024

okay, thanks i will look into that!

@zshipko zshipko merged commit 0e4ef3c into main Sep 16, 2024
@zshipko zshipko deleted the pin-wazero-main branch September 16, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants