feat!: provide plugins get_log_level runtime function & support levels#74
Merged
feat!: provide plugins get_log_level runtime function & support levels#74
Conversation
This was referenced Aug 30, 2024
zshipko
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the extism host env with Rust, as per extism/extism#758
NOTE of breaking change:
I've removed the ability to set the log level on the
*Pluginitself. To align with Rust SDK, this is only an SDK-global setting. You can still add a custom logger to each plugin function. The SDK won't print any logs unless there is a log function set for each plugin. The global setting is in line with how libraries are expected to respect the main application's log level.