fix: better suggestion when encoding is not implemented#843
Merged
zshipko merged 1 commit intoextism:mainfrom Mar 31, 2025
Merged
fix: better suggestion when encoding is not implemented#843zshipko merged 1 commit intoextism:mainfrom
zshipko merged 1 commit intoextism:mainfrom
Conversation
zshipko
approved these changes
Mar 31, 2025
Contributor
zshipko
left a comment
There was a problem hiding this comment.
Thanks for catching this!
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a code snippet that demonstrates the issue:
Because the structs don't derive
encodingthe rust-analyzer gives this suggestion:I don't think this suggestion is correct because i could not find
ToJsonanywhere. Adding#[encoding(Json)]solves the issue (as described in the docs).The final code would look as follows:
And compiles perfectly.
I think the suggestion given by the rust-analyzer is incorrect so i am proposing a fix for this.
Since I'm new to the project, any feedback is appreciated.
Thanks!
Alessandro Ruggiero