Merged
Conversation
Contributor
|
Thank you :) Will have @zshipko peek at it on Monday |
zshipko
approved these changes
Dec 2, 2024
Contributor
zshipko
left a comment
zshipko
left a comment
There was a problem hiding this comment.
Thanks! Test failures are clippy related, I will fix those in a follow up PR.
This was referenced Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrap the
Plugininstance in aRwLockand becausefunction_existsrequires&mut self, I have to acquire a write lock everytime to just check if a function exists, which causes lock contention.This changes it to
&selfsince it doesn't need to mutate.