fix(libextism): improve static linking pkgconfig#726
Conversation
|
I just pushed a commit to fix the libextism example on macOS - the only thing I didn't fix is on macOS |
|
Thanks! The best way of handling it is probably adding another variable to the template, |
|
Alright I can add that - I think I can probably do something similar but avoid adding a variable so we maintain compatibility with existing CLI installations |
|
Maintaining compatibility is better, good idea. |
|
Alright, this seems to be working now - let me know if you see anything that looks off @G4Vi (I don't think you can "review" your own PR) I also have extism/cli#94 ready to merge |
|
Looks good to me. The only thing I wonder about is If you review I can merge without bypassing branch protections. |
|
Including it in |
This includes two fixes:
lld)libpthread, this should be a no-op on systems with modern libc, but should fix static linking on systems with glibc pre 2.34 see https://developers.redhat.com/articles/2021/12/17/why-glibc-234-removed-libpthread and error http://www.cpantesters.org/cpan/report/669fdfc8-25a4-11ef-9502-51fb6d8775ea@zshipko if you could verify
make pkg-config-staticand the resultingexampleexecutable inlibextismworks on Mac that would be greatly appreciated.