refactor: zeroPad to use padStart for improved readability#182
Merged
UlisesGascon merged 3 commits intoexpressjs:masterfrom Nov 11, 2024
Merged
refactor: zeroPad to use padStart for improved readability#182UlisesGascon merged 3 commits intoexpressjs:masterfrom
UlisesGascon merged 3 commits intoexpressjs:masterfrom
Conversation
Replaced the manual loop with `padStart` to simplify the code and improve readability. This aligns with modern JavaScript practices, making the function more concise and easier to maintain. No functional changesjust a cleaner, more efficient approach to padding numbers with leading zeros.
UlisesGascon
reviewed
Nov 7, 2024
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
Thanks for this PR, @Ayoub-Mabrouk! Can you lint the code?
Replaced the manual loop with `padStart` to simplify the code and improve readability. This aligns with modern JavaScript practices, making the function more concise and easier to maintain. No functional changesjust a cleaner, more efficient approach to padding numbers with leading zeros.
…e manual loop with padStart to simplify the code and improve readability. This aligns with modern JavaScript practices, making the function more concise and easier to maintain. No functional changesjust a cleaner, more efficient approach to padding numbers with leading zeros.
bjohansebas
approved these changes
Nov 7, 2024
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
LGTM, this improves the performance of this function
UlisesGascon
approved these changes
Nov 11, 2024
UlisesGascon
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the manual loop with
padStartto simplify the code and improve readability. This aligns with modern JavaScript practices, making the function more concise and easier to maintain. No functional changesjust a cleaner, more efficient approach to padding numbers with leading zeros.