Reflect body-parser changes in 5.x API docs and include those that where missing #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is expressjs@8225868, but for 5.x API.
krzysdz
changed the title
krzysdz
commented
Apr 24, 2025
Comment on lines
+7
to
+10
| <li id="express-raw-middleware"><a href="#express.raw">express.raw()</a></li> | ||
| <li id="express-router"><a href="#express.router">express.Router()</a></li> | ||
| <li id="express-static-middleware"><a href="#express.static">express.static()</a></li> | ||
| <li id="express-text-middleware"><a href="#express.text">express.text()</a></li> |
Contributor
Author
There was a problem hiding this comment.
I've added the menu entries with ids suffixed with -middleware for consistency, but in 4.x express.raw() and express.text() menu items have no such suffix in ids.
I don't think anyone makes links with anchors to menu elements, so it should be ok.
expressjs.com/_includes/api/en/4x/menu.md
Lines 6 to 11 in 9e00f5a
15 tasks
krzysdz
changed the title
bjohansebas
approved these changes
Apr 26, 2025
Member
|
thanks @krzysdz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body-parser change that no longer sets
req.body = {}is noted in migration guide and v5 release post, but has not been reflected inexpress.json(),express.raw(),express.text()andexpress.urlencoded()API documentation.Found by @LorenzoLeonardini in expressjs/express#6432 (comment).
express.raw()andexpress.text()had own.mdfiles with docs, but were not included inexpress.mdandmenu.md(see 8225868 for 4.x) - #1881