Skip to content

Conversation

@dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Feb 25, 2025

The debug logs are not yet available again in the router package, so this PR is dependent on pillarjs/router#151 being merged first. I'll mark this as a draft until that PR is merged.

@dpopp07 dpopp07 requested review from a team as code owners February 25, 2025 16:01
@dpopp07 dpopp07 marked this pull request as draft February 25, 2025 16:01
@netlify
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 8aab64d
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67c86f68347dbe00083868c9
😎 Deploy Preview https://deploy-preview-1819--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas requested a review from a team March 4, 2025 21:30
@bjohansebas bjohansebas marked this pull request as ready for review March 4, 2025 21:31
Signed-off-by: Dustin Popp <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
@dpopp07 dpopp07 force-pushed the dp/router-debug-migration branch from 946ef11 to 8aab64d Compare March 5, 2025 15:36
@dpopp07
Copy link
Contributor Author

dpopp07 commented Mar 5, 2025

All comments have been addressed!

@carlosstenzel carlosstenzel merged commit 5e850e8 into expressjs:gh-pages Mar 21, 2025
8 checks passed
@dpopp07 dpopp07 deleted the dp/router-debug-migration branch March 21, 2025 13:54
@bjohansebas
Copy link
Member

@carlosstenzel, the release hasn't been made on npm yet for the router to have that functionality :( Please wait a bit longer for the next one or comment if this can already be merged.

I should have also mentioned that it couldn't be merged yet until the router had made the release to include that change.

@carlosstenzel
Copy link
Contributor

the release hasn't been made on npm yet for the router to have that functionality :( Please wait a bit longer for the next one or comment if this can already be merged.

I should have also mentioned that it couldn't be merged yet until the router had made the release to include that change.

sorry

@carlosstenzel
Copy link
Contributor

Can we create a label 'do not merge' ?

I will rollback

@bjohansebas
Copy link
Member

We can't overwrite the gh-pages branch, so let's leave it as is. It's not that critical.

I'll open the PR to proceed with the release in router.

Can we create a label 'do not merge'?

I like that label.

@dpopp07
Copy link
Contributor Author

dpopp07 commented Mar 24, 2025

I originally had it as a draft for that reason but in this comment @wesleytodd said

I don't think it matters much if we publish this to the website in advance though as long as we have this [version] specified.

so I don't think it's the end of the world that we went ahead and merged this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants