-
-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: add router debug log change to v5 migration guide #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add router debug log change to v5 migration guide #1819
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Dustin Popp <[email protected]> Co-authored-by: Sebastian Beltran <[email protected]>
946ef11 to
8aab64d
Compare
|
All comments have been addressed! |
|
@carlosstenzel, the release hasn't been made on npm yet for the router to have that functionality :( Please wait a bit longer for the next one or comment if this can already be merged. I should have also mentioned that it couldn't be merged yet until the router had made the release to include that change. |
sorry |
|
Can we create a label 'do not merge' ? I will rollback |
|
We can't overwrite the I'll open the PR to proceed with the release in
I like that label. |
|
I originally had it as a draft for that reason but in this comment @wesleytodd said
so I don't think it's the end of the world that we went ahead and merged this in! |
The debug logs are not yet available again in the
routerpackage, so this PR is dependent on pillarjs/router#151 being merged first. I'll mark this as a draft until that PR is merged.