Added documentation for calling acceptsLanguages without argument #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling req.acceptsLanguages without argument(s) returns an array of languages from the HTTP Accept-Language header.
This is much easier than calling req.get('Accept-Language') because you do not need to parse the Accept-Language header string.
Close expressjs#1401
UlisesGascon
approved these changes
Nov 25, 2023
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
Thanks @dotnetCarpenter. It took me a while to follow the change, but seems clear now that I checked the test file from accepts (https://github.com/jshttp/accepts/blob/master/test/language.js#L12) following the expressjs code (https://github.com/expressjs/express/blob/2a00da2067b7017f769c9100205a2a5f267a884b/lib/request.js#L181).
This is a very useful change in the docs! 👍
crandmck
approved these changes
Mar 4, 2024
15 tasks
krzysdz
added a commit
to krzysdz/expressjs.com
that referenced
this pull request
Apr 24, 2025
krzysdz
added a commit
to krzysdz/expressjs.com
that referenced
this pull request
Apr 25, 2025
expressjs#1402 Co-authored-by: Jon Ege Ronnenberg <[email protected]>
bjohansebas
pushed a commit
that referenced
this pull request
May 1, 2025
* Include 4.18 API doc updates in 5.x 5c98ee4 Co-authored-by: Douglas Christopher Wilson <[email protected]> * Copy acceptsLanguages documentation improvements to 5.x #1402 Co-authored-by: Jon Ege Ronnenberg <[email protected]> * Add warning boxes to {app,res}.render 5e918ea Co-authored-by: Douglas Christopher Wilson <[email protected]> * Copy warning around securing locals to 5.x fcaca7f Co-authored-by: Douglas Christopher Wilson <[email protected]> * Copy res.cookie `partitioned` option docs #1456 Co-authored-by: Rich Hodgkins <[email protected]> * Update req.body to point to built-in middleware a5ca5b0 Co-Authored-By: Douglas Wilson <[email protected]> * Copy setting multiple cookies example to 5.x #1063 Co-Authored-By: Mo <[email protected]> --------- Co-authored-by: krzysdz <[email protected]> Co-authored-by: Douglas Christopher Wilson <[email protected]> Co-authored-by: Jon Ege Ronnenberg <[email protected]> Co-authored-by: Rich Hodgkins <[email protected]> Co-authored-by: Mo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
req.acceptsLanguageswithout argument(s) returns anarrayof languages from the HTTPAccept-Languageheader.This is much easier than calling
req.get('Accept-Language'), because you do not need to parse theAccept-Languageheaderstring.Close #1401