You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
qs's subdeps have a lot of recursion in require cycles as well
all of qs and it's dependencies is maintained by the same developer (could be a security concern)
Might be useful for serverless folks that use express (if there's platform that allows express to be used, at least)
Cons
fast-querystring requires at least Node 8:
it uses object destructuring and trailing commas
it might be possible to convince the author to remove the trailing commas, then it would be usable with Node 6
Node 8 has been out of support for more than 5 years now (support stopped on Jan 1st 2019, according to endoflife.date/nodejs)
Node 0.10 is even older, I can't even find an EOL date for it
fast-querystring doesn't support setting prototypes
this is unsafe either way, though it can probably get released in express v5
Notes
Slightly better performance:
this test was done using the benchmark folder in this repo and just replacing the require call to fast-querystring on a idling 7950X running Node v8.17.0
It might be useful to maybe port to using URLSearchParams which has been supported since Node 10
Pros
qs) vs. ~30 kB (fast-querystring)qs's subdeps have a lot of recursion in require cycles as wellexpress(if there's platform that allowsexpressto be used, at least)Cons
fast-querystringrequires at least Node 8:fast-querystringdoesn't support setting prototypesNotes
benchmarkfolder in this repo and just replacing therequirecall tofast-querystringon a idling 7950X running Node v8.17.0URLSearchParamswhich has been supported since Node 10URLSearchParamsto be pretty slow, though, this needs to be benchmarked first