Skip to content

Conversation

@bjohansebas
Copy link
Member

@bjohansebas bjohansebas changed the title fix(ci): improve package dependencies using caret (^) deps: improve package dependencies using caret (^) Jan 16, 2025
@socket-security
Copy link

socket-security bot commented Jan 16, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected]2.31.0 environment Transitive: eval +115 6.64 MB ljharb
npm/[email protected]6.3.4 Transitive: environment, eval, filesystem +40 1.93 MB titanism

View full report↗︎

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should apply this change until we major rev and drop the old node versions.

@bjohansebas
Copy link
Member Author

Then document it in the RFC/ADR. I had asked if the way forward was to update the CI or wait until we drop support for the old Node versions.

@bjohansebas
Copy link
Member Author

We no longer support older versions, so this can be reviewed again. Ideally, it would go into version 2.

@bjohansebas bjohansebas merged commit f1b3e1c into expressjs:v2 Apr 14, 2025
16 checks passed
@bjohansebas bjohansebas deleted the dependencies-caret branch April 14, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants