perf: use the node require cache instead of custom caching #562
Conversation
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Generally a fan of this. I always wondered why this was done in the first place when lazy loading has worked like this for a LONG TIME.
|
Hi @wesleytodd @UlisesGascon! Apologies for the additional ping. I hope you're both doing well. I noticed this PR has received three approvals and no objections. Please let me know if there’s anything else needed from my side. Thank you so much! |
|
Hey! No worries! I am just getting setup this week to get caught up (again, it is a never ending battle lol). I think this is good to merge, so will do so now. I am not going to prep a release just yet as I want to catch up on the ~500 notifications first to make sure we have the bigger picture plan in mind, but I will hopefully get releases ready for a bunch of this before the end of the month. |
4 participants
This PR replaces the custom caching logic with Node.js's built-in require cache. By leveraging the require cache, the codebase is simplified, performance is improved, and maintenance overhead is reduced. The custom logic has been removed, and the parser loading now relies on
require.