Remove devDependency safe-buffer
#547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Oct 21, 2024
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! I will add the @expressjs/security-wg add reviewer too.
Member
|
We probably want to reflect this change in the |
Member
Author
Is it necessary for a devDependency? |
Member
Oh! you are right, forget my last comment :) |
bjohansebas
approved these changes
Oct 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
safe-bufferpackage from devDependencies as it's no longer needed. Since we no longer support Node.js versions older than 18.0.0, the native Buffer class now fully handles security concerns. Additionally, there are no instances ofnew Buffer(...)usage in the repository.