Skip to content

docs: create a file for captains and committers #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
UlisesGascon wants to merge 4 commits into from
Closed

docs: create a file for captains and committers #18

UlisesGascon wants to merge 4 commits into from

Conversation

@UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Mar 17, 2025 •
edited
Loading

@UlisesGascon UlisesGascon self-assigned this Mar 17, 2025
UlisesGascon added a commit to expressjs/express that referenced this pull request Mar 17, 2025
@UlisesGascon
docs: make reference to external list for captains and committers
675b7c3 
Ref: expressjs/.github#18
@UlisesGascon UlisesGascon mentioned this pull request Mar 17, 2025
Closed
This was referenced Mar 17, 2025
Closed
Closed
bjohansebas
bjohansebas reviewed Mar 17, 2025
View reviewed changes
bjohansebas
bjohansebas reviewed Mar 17, 2025
View reviewed changes
bjohansebas
bjohansebas reviewed Mar 17, 2025
View reviewed changes
@bjohansebas
Copy link
Member

bjohansebas commented Mar 27, 2025

Can we merge this, please?

wesleytodd
wesleytodd requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This covers three orgs. I thought we had discussed that the .github repo was for things that GitHub directly supported (like Security.md and the COC) but that discussions was for the larger cross project things?

I am for sure on board with this file, the format, and especially moving it out of express but I think we should put it in expressjs/discussions/docs instead.

@wesleytodd
Copy link
Member

wesleytodd commented Mar 27, 2025

I just checked to be sure, and right now there is nothing in this repo that is not expressjs org specific and also directly a GitHub supported file. I wanted to make sure I wasn't blocking for now reason, but this would be the first "cross org doc" in this repo and we already have a bunch of other similar things in the discussions repo.

@bjohansebas bjohansebas mentioned this pull request Mar 30, 2025
Merged
bjohansebas added a commit to bjohansebas/.github-express that referenced this pull request Mar 30, 2025
@bjohansebas
port: expressjs#18
b81aee7
@bjohansebas bjohansebas mentioned this pull request Mar 30, 2025
Merged
@UlisesGascon
Copy link
Member Author

UlisesGascon commented Apr 1, 2025

Closed in favor of expressjs/discussions#353

wesleytodd added a commit that referenced this pull request May 21, 2025
@bjohansebas @wesleytodd
feat: move contributing and collaboration guide to .github (#10)
573cb2c 
* docs: add contributing.md

* docs: rename contributing to governance

* port: #18

* docs: add contributing guide for Express collaboration

* docs: update links to captains and committers in governance document

* docs: move governance document to dicussions repo

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

---------

Co-authored-by: Wes Todd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

@jonchurch jonchurch jonchurch approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@UlisesGascon UlisesGascon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UlisesGascon @bjohansebas @wesleytodd @jonchurch