feat: Add support for new IcoMoon app JSON format#356
Merged
Conversation
- Support both old format (icons[].properties) and new format (glyphs[].extras) - Detect format by checking existence of 'icons' or 'glyphs' in config - Add fallback error for invalid config - Font family defaults to 'icomoon' when not in config (new format) Co-authored-by: Cursor <[email protected]>
|
@tomekzaw is attempting to deploy a commit to the Expo Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
amandeepmittal
added a commit
to expo/expo
that referenced
this pull request
Feb 17, 2026
# Why The [new IcoMoon app](https://icomoon.io/new-app) exports a different JSON format than the [old IcoMoon app](https://icomoon.io/app). The current `createIconSetFromIcoMoon` function in `@expo/vector-icons` only supports the old app's output, so users who export from the new app encounter issues. expo/vector-icons#356 adds support for the new format. This documentation update clarifies the situation and points users to that PR until it is released. # How Added a note in the `createIconSetFromIcoMoon` section in the docs about icons. # Test Plan Make sure that the `createIconSetFromIcoMoon` section renders correctly. # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <[email protected]>
This was referenced Feb 20, 2026
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
# Why The [new IcoMoon app](https://icomoon.io/new-app) exports a different JSON format than the [old IcoMoon app](https://icomoon.io/app). The current `createIconSetFromIcoMoon` function in `@expo/vector-icons` only supports the old app's output, so users who export from the new app encounter issues. expo/vector-icons#356 adds support for the new format. This documentation update clarifies the situation and points users to that PR until it is released. # How Added a note in the `createIconSetFromIcoMoon` section in the docs about icons. # Test Plan Make sure that the `createIconSetFromIcoMoon` section renders correctly. # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for new IcoMoon app JSON output schema in
createIconSetFromIcoMoonfunction while keeping compatibility for the old IcoMoon app JSON output schema.