feature(website): add per-platform device frame options when embedding snacks#425
Merged
Merged
Conversation
Kudo
approved these changes
May 17, 2023
byCedric
force-pushed
the
@bycedric/website/add-device-frame-for-embeds
branch
from
May 17, 2023 14:43
c9641a4 to
7cd88b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #422
It seems that the react native docs wasn't aware of our upgrade to newer device frames. We did this to avoid an outdated look when using Appetize.
Allowing everyone who embed Snacks to use a fixed device frame would avoid this in the future.
How
device-frame-androidanddevice-frame-iosoptionsTest Plan
Going to deploy this to staging, and validate through the react native docs. See the updated docs on how to use it.