[cli] Fix error message for launching updates on iOS physical devices#348
Merged
gabrieldonadel merged 1 commit intoJun 20, 2026
Merged
Conversation
The error thrown in launchUpdateOnIOSAsync was missing the word "devices", so it read "Launching updates on iOS physical is not supported yet". The matching guard in launchUpdateOnExpoGoIosAsync already reads "...iOS physical devices is not supported yet". Align the two messages.
patrickwehbe
force-pushed
the
cli-fix-ios-launch-update-error-message
branch
from
June 20, 2026 11:13
c8c2790 to
94c2d30
Compare
gabrieldonadel
approved these changes
Jun 20, 2026
gabrieldonadel
left a comment
gabrieldonadel
left a comment
Member
There was a problem hiding this comment.
@patrickwehbe thanks for helping with this! 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The error thrown when launching an update on an iOS physical device is missing a word. In
launchUpdateOnIOSAsyncit currently reads:The equivalent guard in
launchUpdateOnExpoGoIosAsync(same file, line 115) already has the correct wording:Both run the same
!isSimulatorcheck, so the two messages should match.How
Added the missing word "devices" to the error string on line 151 of
apps/cli/src/commands/LaunchUpdate.tsso it matches its sibling on line 115. Also added a changelog entry under the Unpublished bug fixes section.Test Plan
This is a one-word change to a string literal inside an existing
throw new Error(...). The two error messages in the file are now identical, which can be confirmed by searching the file for "Launching updates on iOS physical" and seeing both lines read the same.