[menu-bar] Fix crash when opening app via deep link from cold start#320
Merged
gabrieldonadel merged 2 commits intomainfrom Mar 18, 2026
Merged
[menu-bar] Fix crash when opening app via deep link from cold start#320gabrieldonadel merged 2 commits intomainfrom
gabrieldonadel merged 2 commits intomainfrom
Conversation
tchayen
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expo Orbit crashes when opened via deep link (
open "expo-orbit:///download/?url=...") if the app is not already running.Closes #311
How
The crash was caused by a race condition during app startup. The
applicationWillFinishLaunchingregisters the Apple Event handler for URL schemes, butpopoverManageris only initialized later inloadReactNativeWindow(called aftersuper.applicationDidFinishLaunching). When macOS launches the app in response to a deep link, the URL Apple Event can be dispatched duringsuper.applicationDidFinishLaunching(beforepopoverManageris set). SincepopoverManageris declared as an implicitly unwrapped optional (PopoverManager!), accessing it whilenilcauses a SIGTRAP crash.By using optional chaining on
popoverManager, the function call is safely skipped if the manager isn't initialized yet.RCTLinkingManagerwill still receive the URL event, and the deep link gets processed once React Native finishes loading.Test Plan
open "expo-orbit:///download/?url=https%3A%2F%2Fexpo.dev%2Fartifacts%2Feas%2Ff33ukJUZmMKb88egay8Tra.tar.gz"Screen.Recording.2026-03-17.at.23.50.16.mov