[menu-bar] Optimize code for React 19 #307
Merged
gabrieldonadel merged 6 commits intomainfrom Feb 3, 2026
Merged
Conversation
gabrieldonadel
changed the title
tsapeta
approved these changes
Feb 2, 2026
Contributor
tsapeta
left a comment
tsapeta
left a comment
There was a problem hiding this comment.
Looks good, just two nitpicks 😉
Comment on lines
+23
to
+26
| ref?: React.Ref<{ setNative: (native: { value?: boolean }) => void }>; | ||
| }) => { | ||
| const nativeSwitchRef = useRef<React.ElementRef<typeof NativeCheckbox> | null>(null); | ||
| const [native, setNative] = useState<{ value?: boolean }>({ value: undefined }); |
Contributor
There was a problem hiding this comment.
{ value?: boolean }appears in two places so maybe it deserves a type declaration 😄- does the value actually need to be wrapped in an object?
Member
Author
There was a problem hiding this comment.
Ohh this code was just copied from the react-native-macos Switch.js a few years ago. Let me refactor this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that we updated React to version 19, we can take advantage of some new features
How
React.forwardReftorefas a propTest Plan
Run menu-bar locally