[menu-bar][macos] Use expo-web-browser for authentication#276
Merged
gabrieldonadel merged 2 commits intomainfrom Jun 11, 2025
Merged
[menu-bar][macos] Use expo-web-browser for authentication#276gabrieldonadel merged 2 commits intomainfrom
gabrieldonadel merged 2 commits intomainfrom
Conversation
6ecb498 to
a538ead
Compare
a538ead to
a531900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With expo/expo#37352 we can use
expo-web-browserfor our authentication on macOS instead of maintaining a custom native moduleHow
Add
expo-web-browserdependency and deleteTest Plan
Screen.Recording.2025-06-11.at.14.28.27.mov