[electron] Fix multi display popover position logic#265
Merged
gabrieldonadel merged 3 commits intomainfrom Jun 2, 2025
Merged
Conversation
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-electron-popover-position
branch
from
194a611 to
c82da7d
Compare
alanjhughes
approved these changes
May 22, 2025
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-electron-popover-position
branch
from
c82da7d to
2ba3b46
Compare
gabrieldonadel
added a commit
that referenced
this pull request
Jun 2, 2025
* [electron] Fix multi display popover position logic * Add changelog entry * Fix linux edge case
|
Thank you very much @gabrieldonadel for sorting this bug out. I can confirm that it is working for me now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #231
How
Update popover window position logic to use the current display based on the click bounds
Test Plan
Run locally on macos, linux and windows using multiple displays