[menu-bar] Bump react-native-macos to 0.76.6 and remove patch#232
Merged
gabrieldonadel merged 4 commits intomainfrom Dec 18, 2024
Merged
[menu-bar] Bump react-native-macos to 0.76.6 and remove patch#232gabrieldonadel merged 4 commits intomainfrom
gabrieldonadel merged 4 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As reported in #224, NativeEventEmitter is broken in react-native-macos 0.76.0, causing parts of our app to crash, we manually patched this in #225 but now that react-native-macos 0.76.6 is out we can remove the patch
How
Update react-native-macos to 0.76.6 and remove patch
Test Plan
Run MenuBar locally