[menu-bar][electron] Implement linux support for auto updater#229
Merged
gabrieldonadel merged 5 commits intomainfrom Dec 3, 2024
Merged
[menu-bar][electron] Implement linux support for auto updater#229gabrieldonadel merged 5 commits intomainfrom
gabrieldonadel merged 5 commits intomainfrom
Conversation
alanjhughes
reviewed
Dec 3, 2024
Comment on lines
+44
to
+49
| const installCommand = | ||
| fileExtension === '.deb' | ||
| ? ['dpkg', '-i', this.lastUpdatePath] | ||
| : fileExtension === '.rpm' | ||
| ? ['rpm', '-i', '--force', this.lastUpdatePath] | ||
| : null; |
Contributor
There was a problem hiding this comment.
It's kind of difficult to read. What do you think about moving this to a function? Something like this maybe
createInstallCommand(path: string) {
switch (path) {
case '.deb':
return ['dpkg', '-i', this.lastUpdatePath];
case '.rpm':
return ['rpm', '-i', '--force', this.lastUpdatePath];
default:
throw new Error('Unsupported package format. Only .deb and .rpm are supported.');
}
}
Member
Author
There was a problem hiding this comment.
good call, updated
alanjhughes
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Expo Orbit 2.0 did not support auto update on linux yet
How
Implement a custom logic to support .deb and .rpm updates on linux
Test Plan
Run menu bar locally and update the version