Skip to content

Fix build issues on linux and windows#220

Merged
gabrieldonadel merged 15 commits intomainfrom
@gabrieldonadel/publish
Nov 21, 2024
Merged

Fix build issues on linux and windows#220
gabrieldonadel merged 15 commits intomainfrom
@gabrieldonadel/publish

Conversation

@gabrieldonadel
Copy link
Copy Markdown
Member

@gabrieldonadel gabrieldonadel commented Nov 21, 2024

Why

Final round of testing for the Windows and linux releases

Closes ENG-12525
Closes ENG-12523

How

  • Fix vite not bundling CLI packages correctly
  • Simplify electron/forge config
  • Fix icons in linux
  • Fix orbit button not showing up in Snack when using Firefox
  • Remove inline requires from eas-shared given that this syntax is not supported by rollupjs

Test Plan

macOS
image

Linux

image

Windows

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants