[menu-bar] Add electron support for Checkbox component#161
Merged
gabrieldonadel merged 2 commits intomainfrom Feb 6, 2024
Merged
[menu-bar] Add electron support for Checkbox component#161gabrieldonadel merged 2 commits intomainfrom
gabrieldonadel merged 2 commits intomainfrom
Conversation
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
768582e to
cee8796
Compare
Base automatically changed from
@gabrieldonadel/electron-window-manager
to
main
February 5, 2024 22:26
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-checkbox
branch
from
09a31ba to
7471849
Compare
alanjhughes
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The current Checkbox component does not show the label on the web
How
Refactor Checkbox component, move native part to a different file and add web implementation
Test Plan
Screen.Recording.2024-02-02.at.16.45.29.mov
Screen.Recording.2024-02-02.at.16.52.16.mov