[menu-bar] Add electron support for WindowManager#158
Merged
gabrieldonadel merged 6 commits intomainfrom Feb 5, 2024
Merged
Conversation
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
6702bb5 to
d702796
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-auto-resizer-root-view
branch
2 times, most recently
from
2e8e5ef to
684b4cc
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
bf863e2 to
b53499c
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-auto-resizer-root-view
branch
from
684b4cc to
0ea95d6
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
b53499c to
462c813
Compare
Base automatically changed from
@gabrieldonadel/electron-auto-resizer-root-view
to
main
February 2, 2024 17:31
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
9fd0d0f to
77361ae
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/electron-window-manager
branch
from
768582e to
cee8796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-11332
How
[[RCTRootView alloc] initWithBridge:bridge moduleName:moduleName initialProperties:@{}];openPopoverandclosePopoverfunctions to MenuBarModuleTest Plan
On Windows:
Screen.Recording.2024-02-02.at.15.01.48.mov