Skip to content

continuous-deploy-fingerprint: eas 22 github commenting is broken #358

Closed

Description

@Yash-Singh1

Description of the bug

How would you shortly summarise the issue?

The build completes and succeeds on the expo dashboard but the github comment doesn't come through and the github action for the deploy fails.

To Reproduce

What steps did you perform which led to this issue?

Use continuous-deploy-fingerprint normally with eas-version: latest

Expected behavior

What did you expect to have happened?

It doesn't error when sending the github comment

Actual behavior

What did it actually result in?

It errors when sending the github comment with
Cannot read properties of undefined (reading 'ownerAccount')

Additional context

Can you further explain the issue? E.g., information about version/environment or screenshots.

eas-cli 22 renamed build JSON fields: project → app, channel → updateChannel, runtimeVersion → runtime. The fingerprint action still does this when posting the PR comment:

export function getBuildLogsUrl(build: BuildInfo): string {
  const { project } = build;
  const path = `/accounts/${project.ownerAccount.name}/projects/${project.slug}/builds/${build.id}`;

build.project is now undefined, so you get Cannot read properties of undefined (reading 'ownerAccount'). That matches the log: matching builds are found, “Publishing EAS Update...” runs for ~2 minutes (the update itself likely succeeded), then the action dies on the comment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions