Skip to content
This repository was archived by the owner on Jan 18, 2024. It is now read-only.

Move root webpack.config.js check to XDL#437

Merged
EvanBacon merged 6 commits into
masterfrom
@evanbacon/expo-web/remove-root-config-option
Mar 20, 2019
Merged

Move root webpack.config.js check to XDL#437
EvanBacon merged 6 commits into
masterfrom
@evanbacon/expo-web/remove-root-config-option

Conversation

@EvanBacon

Copy link
Copy Markdown
Contributor

Now you can create a webpack.config.js in your root project which reexports @expo/webpack-config without creating a stack overflow.

@EvanBacon EvanBacon self-assigned this Mar 19, 2019
@EvanBacon EvanBacon requested a review from fson March 19, 2019 06:05
Comment thread packages/xdl/src/Web.js Outdated
Comment thread packages/webpack-config/webpack.config.js Outdated

@fson fson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you.

@fson fson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EvanBacon EvanBacon merged commit 6a5fa9b into master Mar 20, 2019
@EvanBacon EvanBacon deleted the @evanbacon/expo-web/remove-root-config-option branch March 20, 2019 18:10
mfulton26 added a commit to mfulton26/expo-cli that referenced this pull request Oct 19, 2022
[Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database](GHSA-9pgh-qqpf-7wqj)

`@xmldom/xmldom` has already been patched:

[fix: Avoid iterating over prototype properties by karfau · Pull Request expo#437 · xmldom/xmldom](xmldom/xmldom#437)

newer versions exist but this is the latest patch version and there shoudln't be any breaking changes

`yarn build` and `yarn test`
EvanBacon pushed a commit that referenced this pull request Oct 28, 2022
[Improperly Controlled Modification of Object Prototype Attributes ('Prototype Pollution') in @xmldom/xmldom and xmldom · CVE-2022-37616 · GitHub Advisory Database](GHSA-9pgh-qqpf-7wqj)

`@xmldom/xmldom` has already been patched:

[fix: Avoid iterating over prototype properties by karfau · Pull Request #437 · xmldom/xmldom](xmldom/xmldom#437)

newer versions exist but this is the latest patch version and there shoudln't be any breaking changes

`yarn build` and `yarn test`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants