Skip to content

Conversation

@sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Aug 27, 2020

Why

It's obsolete and actually worse than the other one.

How

Removed all usages of the class and removed the class too.

Test Plan

Android Client compiles well.

Note: I'm not about the sections where to put this change. I thought: @unimodules/core from now on seizes to be compatible with older expo-brightness and expo-sharing, so it's kind of breaking.

@sjchmiela sjchmiela marked this pull request as ready for review August 27, 2020 14:44
@sjchmiela sjchmiela merged commit 0dc9ee4 into master Aug 28, 2020
@sjchmiela sjchmiela deleted the @sjchmiela/remove-invalid-exception branch August 28, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants