Skip to content

Conversation

@barthap
Copy link
Contributor

@barthap barthap commented Aug 27, 2020

Why

Upgraded TypeScript to 4.0.2 to keep us more up-to-date. All new features are described here

One of them is support for @deprecated annotation, I opened a separate PR: #9959.

One breaking change is that now delete can be used only on optionals:

type SomeType = {
  a?: number;
  b: number;
};
const someObj: SomeType = { a: 1, b: 2 };

delete someObj.a;   // OK
delete someObj.b;   // ERROR: The operand of a 'delete' operator must be optional.

How

Followed #8280 and did it the same way.

Updated typescript and ts-jest in expo-module-scripts, resolved breaking change conflicts, rebuilt packages.

Test Plan

Ran et check-packages -a until all packages passed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2020

Fails
🚫

📋 Missing Changelog

🛠 Add missing entries to:

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-ads-admob/CHANGELOG.md b/packages/expo-ads-admob/CHANGELOG.md
index aeb3bfb1..1cb65bd7 100644
--- a/packages/expo-ads-admob/CHANGELOG.md
+++ b/packages/expo-ads-admob/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-18
 
 ### 🎉 New features

diff --git a/packages/expo-ads-facebook/CHANGELOG.md b/packages/expo-ads-facebook/CHANGELOG.md
index a9e64831..05a2b95f 100644
--- a/packages/expo-ads-facebook/CHANGELOG.md
+++ b/packages/expo-ads-facebook/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.4.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-app-auth/CHANGELOG.md b/packages/expo-app-auth/CHANGELOG.md
index 5d0f097d..d05deb66 100644
--- a/packages/expo-app-auth/CHANGELOG.md
+++ b/packages/expo-app-auth/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.2.0 — 2020-08-18
 
 ### 🎉 New features

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index d2f50a77..401fc83d 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.2.0 — 2020-08-18
 
 ### 🎉 New features

diff --git a/packages/expo-auth-session/CHANGELOG.md b/packages/expo-auth-session/CHANGELOG.md
index caac40c9..9a072bc4 100644
--- a/packages/expo-auth-session/CHANGELOG.md
+++ b/packages/expo-auth-session/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 1.5.0 — 2020-08-26
 
 ### 🎉 New features

diff --git a/packages/expo-av/CHANGELOG.md b/packages/expo-av/CHANGELOG.md
index 3e06efcd..57ad7b11 100644
--- a/packages/expo-av/CHANGELOG.md
+++ b/packages/expo-av/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.6.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-barcode-scanner/CHANGELOG.md b/packages/expo-barcode-scanner/CHANGELOG.md
index 60fa126a..ff86dad2 100644
--- a/packages/expo-barcode-scanner/CHANGELOG.md
+++ b/packages/expo-barcode-scanner/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.0.0 — 2020-08-18
 
 ### 🛠 Breaking changes

diff --git a/packages/expo-blur/CHANGELOG.md b/packages/expo-blur/CHANGELOG.md
index 29e8c8ef..a5747e2f 100644
--- a/packages/expo-blur/CHANGELOG.md
+++ b/packages/expo-blur/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.2.0 — 2020-08-18
 
 ### 🎉 New features

diff --git a/packages/expo-camera/CHANGELOG.md b/packages/expo-camera/CHANGELOG.md
index 4b440784..dcafa0b4 100644
--- a/packages/expo-camera/CHANGELOG.md
+++ b/packages/expo-camera/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.0.0 — 2020-08-18
 
 ### 🛠 Breaking changes

diff --git a/packages/expo-document-picker/CHANGELOG.md b/packages/expo-document-picker/CHANGELOG.md
index e74e4582..5e7d616c 100644
--- a/packages/expo-document-picker/CHANGELOG.md
+++ b/packages/expo-document-picker/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.4.0 — 2020-08-18
 
 ### 🐛 Bug fixes

diff --git a/packages/expo-facebook/CHANGELOG.md b/packages/expo-facebook/CHANGELOG.md
index 3aff1897..dc9a9aa0 100644
--- a/packages/expo-facebook/CHANGELOG.md
+++ b/packages/expo-facebook/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.0.0 — 2020-08-18
 
 ### 🛠 Breaking changes

diff --git a/packages/expo-firebase-analytics/CHANGELOG.md b/packages/expo-firebase-analytics/CHANGELOG.md
index dbb2694b..5f0e67e5 100644
--- a/packages/expo-firebase-analytics/CHANGELOG.md
+++ b/packages/expo-firebase-analytics/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 2.5.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-firebase-recaptcha/CHANGELOG.md b/packages/expo-firebase-recaptcha/CHANGELOG.md
index a2bb4b3e..f9341fca 100644
--- a/packages/expo-firebase-recaptcha/CHANGELOG.md
+++ b/packages/expo-firebase-recaptcha/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 1.2.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-font/CHANGELOG.md b/packages/expo-font/CHANGELOG.md
index 476012c8..2456a425 100644
--- a/packages/expo-font/CHANGELOG.md
+++ b/packages/expo-font/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-gl/CHANGELOG.md b/packages/expo-gl/CHANGELOG.md
index 5aafca7b..343c2a85 100644
--- a/packages/expo-gl/CHANGELOG.md
+++ b/packages/expo-gl/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.1.1 — 2020-08-26
 
 ### 🎉 New features

diff --git a/packages/expo-google-sign-in/CHANGELOG.md b/packages/expo-google-sign-in/CHANGELOG.md
index 8a8258dc..86784466 100644
--- a/packages/expo-google-sign-in/CHANGELOG.md
+++ b/packages/expo-google-sign-in/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-linear-gradient/CHANGELOG.md b/packages/expo-linear-gradient/CHANGELOG.md
index 55bb0eb7..1bf6e961 100644
--- a/packages/expo-linear-gradient/CHANGELOG.md
+++ b/packages/expo-linear-gradient/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-linking/CHANGELOG.md b/packages/expo-linking/CHANGELOG.md
index 80ead7b2..53ae286c 100644
--- a/packages/expo-linking/CHANGELOG.md
+++ b/packages/expo-linking/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 1.0.4 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-localization/CHANGELOG.md b/packages/expo-localization/CHANGELOG.md
index a8774f6b..da91d96c 100644
--- a/packages/expo-localization/CHANGELOG.md
+++ b/packages/expo-localization/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.0.0 — 2020-08-18
 
 ### 🛠 Breaking changes

diff --git a/packages/expo-module-template/CHANGELOG.md b/packages/expo-module-template/CHANGELOG.md
index 6648b857..c4e192d6 100644
--- a/packages/expo-module-template/CHANGELOG.md
+++ b/packages/expo-module-template/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.4.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-notifications/CHANGELOG.md b/packages/expo-notifications/CHANGELOG.md
index 0c143136..20921fde 100644
--- a/packages/expo-notifications/CHANGELOG.md
+++ b/packages/expo-notifications/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 0.7.1 — 2020-08-26
 
 _This version does not introduce any user-facing changes._
@@ -80,11 +82,7 @@ _This version does not introduce any user-facing changes._
 
 - Added native permission requester that will let developers call `Permissions.getAsync(Permissions.NOTIFICATIONS)` (or `askAsync`) when this module is installed. ([#8486](https://github.com/expo/expo/pull/8486) by [@sjchmiela](https://github.com/sjchmiela))
 
-> Note that the effect of this method is the same as if you called `Notifications.getPermissionsAsync()` (or `requestPermissionsAsync`) and then `Notifications.getDevicePushTokenAsync()`—it tries to both ask the user for user-facing notifications permissions and then tries to register the device for remote notifications. We are planning to deprecate the `.NOTIFICATIONS` permission soon.## 0.2.0 — 2020-05-27### 🛠 Breaking changes
-
-> Note that this may or may not be a breaking change for you — if you'd expect the notification to be automatically dismissed when tapped on this is a bug fix and a new feature (fixes inconsistency between platforms as on iOS this is the only supported behavior; adds the ability to customize the behavior on Android). If you'd expect the notification to only be dismissed at your will this is a breaking change and you'll need to add `autoDismiss: false` to your notification content inputs.- Changed the default notification behavior on Android to be automatically dismissed when clicked. This is customizable with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))### 🎉 New features
-
-- Added the ability to configure whether the notification should be automatically dismissed when tapped on or not (on Android) with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))
+> Note that the effect of this method is the same as if you called `Notifications.getPermissionsAsync()` (or `requestPermissionsAsync`) and then `Notifications.getDevicePushTokenAsync()`—it tries to both ask the user for user-facing notifications permissions and then tries to register the device for remote notifications. We are planning to deprecate the `.NOTIFICATIONS` permission soon.## 0.2.0 — 2020-05-27### 🛠 Breaking changes> Note that this may or may not be a breaking change for you — if you'd expect the notification to be automatically dismissed when tapped on this is a bug fix and a new feature (fixes inconsistency between platforms as on iOS this is the only supported behavior; adds the ability to customize the behavior on Android). If you'd expect the notification to only be dismissed at your will this is a breaking change and you'll need to add `autoDismiss: false` to your notification content inputs.- Changed the default notification behavior on Android to be automatically dismissed when clicked. This is customizable with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))### 🎉 New features- Added the ability to configure whether the notification should be automatically dismissed when tapped on or not (on Android) with the `autoDismiss` parameter of `NotificationContentInput`. ([#8241](https://github.com/expo/expo/pull/8241) by [@thorbenprimke](https://github.com/thorbenprimke))
 - Added `DailyTriggerInput` that allows scheduling a daily recurring notification for a specific hour and minute. It is supported on both iOS and Android. ([#8199](https://github.com/expo/expo/pull/8199) by [@thorbenprimke](https://github.com/thorbenprimke))
 
 ### 🐛 Bug fixes

diff --git a/packages/expo-payments-stripe/CHANGELOG.md b/packages/expo-payments-stripe/CHANGELOG.md
index b3270f1a..267ce57f 100644
--- a/packages/expo-payments-stripe/CHANGELOG.md
+++ b/packages/expo-payments-stripe/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-print/CHANGELOG.md b/packages/expo-print/CHANGELOG.md
index 4dbd0ba9..d6da9e53 100644
--- a/packages/expo-print/CHANGELOG.md
+++ b/packages/expo-print/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 9.1.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-sms/CHANGELOG.md b/packages/expo-sms/CHANGELOG.md
index 9f0be03f..45d97a22 100644
--- a/packages/expo-sms/CHANGELOG.md
+++ b/packages/expo-sms/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.3.0 — 2020-08-11
 
 ### 🐛 Bug fixes

diff --git a/packages/expo-sqlite/CHANGELOG.md b/packages/expo-sqlite/CHANGELOG.md
index 93f4b85a..f04d0d2e 100644
--- a/packages/expo-sqlite/CHANGELOG.md
+++ b/packages/expo-sqlite/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 8.4.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

diff --git a/packages/expo-status-bar/CHANGELOG.md b/packages/expo-status-bar/CHANGELOG.md
index 5de071a6..93066a04 100644
--- a/packages/expo-status-bar/CHANGELOG.md
+++ b/packages/expo-status-bar/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 1.0.2 — 2020-06-25
 
 ### 🐛 Bug fixes

diff --git a/packages/expo-video-thumbnails/CHANGELOG.md b/packages/expo-video-thumbnails/CHANGELOG.md
index 182dd006..edeb1fe1 100644
--- a/packages/expo-video-thumbnails/CHANGELOG.md
+++ b/packages/expo-video-thumbnails/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- Upgrade packages to TypeScript 4.0. ([#9960](https://github.com/expo/expo/pull/9960) by [@barthap](https://github.com/barthap))
+
 ## 4.3.0 — 2020-08-18
 
 _This version does not introduce any user-facing changes._

Generated by 🚫 dangerJS against 2119219

@barthap barthap force-pushed the @barthap/typescript-update-4.0 branch from ab02e56 to 2208777 Compare August 27, 2020 11:54
@barthap barthap requested a review from ide August 27, 2020 12:15
@barthap barthap marked this pull request as ready for review August 28, 2020 06:48
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that this CI failure is not related before committing:

[12:00:08] Module not found: Error: Can't resolve 'react-native-reanimated' in '/home/runner/work/expo/expo/node_modules/@react-navigation/drawer/lib/module/views'
[12:00:08] Error: Module not found: Error: Can't resolve 'react-native-reanimated' in '/home/runner/work/expo/expo/node_modules/@react-navigation/drawer/lib/module/views'
    at /@expo/[email protected]/src/Webpack.ts:281:23
    at finalCallback (/home/runner/.config/yarn/global/node_modules/webpack/lib/Compiler.js:257:39)
    at onCompiled (/home/runner/.config/yarn/global/node_modules/webpack/lib/Compiler.js:265:20)
    at /home/runner/.config/yarn/global/node_modules/webpack/lib/Compiler.js:670:21
    at eval (eval at create (/home/runner/.config/yarn/global/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:46:1)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

@barthap
Copy link
Contributor Author

barthap commented Aug 28, 2020

Hi @ide,
I have already asked about it, and @tsapeta told me that it was caused by @bbarthec doing Reanimated v2 stuff.

Edit: Seems that the same issue happened to #9961

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, the CI fail should be gone by now on master, so just rebase to see it fixed! 👍

@barthap barthap force-pushed the @barthap/typescript-update-4.0 branch from 2208777 to 2119219 Compare August 28, 2020 16:40
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@barthap
Copy link
Contributor Author

barthap commented Aug 28, 2020

After rebasing onto current master the CI passes 🎉

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉🎉 Awesome 🚀🚀🚀

@bbarthec bbarthec merged commit a706cd9 into master Aug 31, 2020
@bbarthec bbarthec deleted the @barthap/typescript-update-4.0 branch August 31, 2020 10:21
Jamedjo pushed a commit to Jamedjo/expo that referenced this pull request Feb 4, 2021
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants